Repository navigation
fix(desktop): drop pull-request panes saved before they carried a repository - #7869
Conversation
…ository A pull-request pane persisted by an earlier build stores only its number, so after #7823 re-keyed the pane by repository and number, reopening a workspace that still had one open threw while rendering the pane header and took down the workspace view. The read-time layout heal now removes such a pane from its tab, promoting its split sibling, and drops a tab left empty. Refs DESKTOP-1BT
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
ChangesPull-request pane sanitization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established for this change; it is mergeable after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The cleanup is limited to locally saved pane layouts and does not appear to expand access or authority. It preserves panes with the current repository field, though security validation is incomplete. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…ds (#7873) The 1.30.2 canary built at ef00bb7 rendered with most Tailwind utilities losing to preflight: padding, gaps, borders and popover positioning all collapsed. #7869 gave dashboardSidebarLocal/schema.ts a value import from the @superset/panes barrel, which pulled panes' TabBar into the entry graph. Its JS was tree-shaken, but OverflowFadeText's `import "../fade-edge.css"` survived as a side effect, and landed in the entry stylesheet ahead of globals.css. fade-edge.css wraps its rules in `@layer utilities`, so the utilities layer was declared first — the lowest priority — and Tailwind's base layer beat every utility. Importing globals.css before anything else makes Tailwind's layer order the first thing the entry stylesheet declares, whatever layered CSS a later import drags into the entry chunk. Verified: a production renderer build now emits properties, theme, base, components, utilities before the fade-edge block (the canary's index CSS opened with `@layer utilities`); the dev app over CDP renders the sidebar and new-workspace view with utilities applied.
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30 Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)". Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23 were covered by #7771. Changes - Pages: no auto-open on publish (#7790); page links and URL links split into their own settings (#7916, #7962, #7946); Listening agents menu with per-row stop and Add listening agent (#7724, #7820, #7919); globe on the Share button (#7766); Report on public pages (#7886); agents offer a page (#7759). Files: pages.mdx, cli/cli-reference.mdx. - Settings moves: Links replaced by Browser and Files & Editor (#7916, #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx. - Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916), open and save files outside the workspace (#7897, #7982), Copy as Markdown (#7591), per-pane error screen (#7983). File: editor.mdx. - Terminal copy follows Ghostty's whitespace rules (#7868). File: terminal-integration.mdx. - Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx, cli/cli-reference.mdx. - Host: superset start --daemon --auto-update and update-lock permission errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx. - Removed the mcp CLI section and the Connected Service Plugins section: #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx, cli/cli-reference.mdx. - Slack page unfurls and details panel (#7817, #7821, #7914, #7957). File: use-with-slack.mdx. - Workspaces: instant creation with background naming (#7518); recoverable project deletion (#7896). File: workspaces.mdx. - Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx. - Ship controls and open-in button moved to the right sidebar strip (#7958). Files: diff-viewer.mdx, use-with-ide.mdx. Deliberately skipped - Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule): #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863 #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981 #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR). - Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955. - Already documented in their own PRs: #7917, #7921. - Removed feature never documented: #7796 Google Calendar triggers. - Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872. - Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792, #7798, #7761, #7948, #7949, #7951, #7827. - Reverted security trio: #7828 #7829 #7830 (reverted by #7834). - Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756 #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860 #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome. - Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810 #7814 #7816 #7889 #7968. - Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774 #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895 #7909 #7933 #7934 #7942 #7944 #7965 #7966. Validation: bun run --cwd apps/docs typecheck, bun run lint:fix, bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings), git diff --check. * chore: log weekly docs update follow-ups * docs: tighten review findings in the weekly update Only the page creator can stop or add listening agents. On focus change also saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do not unfurl. Model picker coverage matches agent-models.ts.
Problem
Opening a v2 workspace that still had a pull-request pane open from a build before #7823 throws while rendering that pane's header, because the pane's persisted data has no repository name. Panes have no error boundary of their own, so the whole workspace view falls to the content error screen, and it comes back every time that workspace is opened. So far this has only shown up on canary builds. The next stable release ships #7823, so every stable user with a PR pane open when they upgrade would hit it.
Root cause
#7823 changed
PullRequestPaneDatafrom{ prNumber, projectId? }to{ repoFullName, number }. Pane layouts are persisted in thev2WorkspaceLocalStatelocalStorage collection and are read back throughsanitizePaneLayout, but that heal only checks layout structure. It passes pane data through unchanged, so a pre-#7823 PR pane reachesusePullRequestPaneDetail, which readsref.repoFullName.toLowerCase(). That data can't be migrated at read time: the old pane borrowed its repository from the workspace's project, which the renderer only learns later, from the host.Fix
sanitizePaneLayout, the existing read-time heal for legacy layout shapes, now removes anypull-requestpane whose data has no stringrepoFullName. It uses the panes package'sremovePaneFromLayout, so a split sibling is promoted, and a tab left with no panes is dropped.activePaneIdis repaired when the active pane was the one removed. The person can reopen the PR from the Changes pane or the sidebar as usual.Panes of other kinds, and PR panes that already use the new shape, are left untouched (there is a negative test for this).
Verification
Before the fix, the new drop test failed (
42 pass, 1 fail) and the keep test passed. After the fix, both pass.Refs DESKTOP-1BT
Summary by cubic
Fixes desktop workspaces that crash when reopening a saved pull-request pane from a build before the pane carried
repoFullName. The layout heal now drops those legacy panes, promotes the split sibling, and repairs the active pane or tab, so the workspace opens and the PR can be reopened normally. Modern PR panes and other pane kinds are untouched.Written for commit f28bf8b. Summary will update on new commits.
Summary by CodeRabbit